search

M4thG33k / TombManyGraves2

A partial re-write of Tomb Many Graves for Minecraft 1.11+
GNU General Public License v3.0
8 stars 8 forks source link

Grave Fails to Find Suitable Location in the Deep Dark #45

Open NielsPilgaard opened 5 years ago

NielsPilgaard commented 5 years ago

Describe the bug A grave fails to spawn when dying in The Deep Dark dimension, from Extra Utilities 2. This happens in the modpack Enigmatica 2: Expert version 1.50a

To Reproduce Steps to reproduce the behavior:

  1. Go to the Deep Dark, by standing on a Deep Dark Portal
  2. Use the command /kill
  3. See error

Expected behavior A grave to spawn at the place of death.

Screenshots billede

RMcD94 commented 4 years ago

Still happens

BlackQuests commented 4 years ago

I did some investigating. The grave fails to spawn because of this line https://github.com/M4thG33k/TombManyGraves2/blob/f98cfdbec9aa38674e9489b82ae3ad135d0b0b77/src/main/java/com/m4thg33k/tombmanygraves/events/CommonEvents.java#L224

the call world.getActualHeight() returns 128 while the deep dark's max height is 255. I confirmed this by going below 128 where it does indeed spawn a grave. I'll attempt to fix this myself if possible. The fault may lie with Extra Utilities but I need to investigate the getActualHeight() code more to determine that

NielsPilgaard commented 4 years ago

I doubt Extra Utilities would update, even if they're at fault tbh :)