search

M66B / XPrivacy

XPrivacy - The ultimate, yet easy to use, privacy manager
http://forum.xda-developers.com/xposed/modules/xprivacy-ultimate-android-privacy-app-t2320783
GNU General Public License v3.0
2.08k stars 527 forks source link

Debugging in Eclipse broken after 1.99.47 #1431

Closed mtbgithub closed 10 years ago

mtbgithub commented 10 years ago

As I reported yesterday in xda (http://forum.xda-developers.com/showthread.php?p=50527433), upgrading from 1.99.47 to 51 (and 52) broke debugging in Eclipse for me, causing some form of infinite loop in the xposed framework to be reported in Eclipse.

I subsequently reported this in the xposed thread on xda (http://forum.xda-developers.com/showthread.php?p=50536931) and got a reply where rovo89 has suggested the following...

"A module has hooked the constructor of Object. When this happens, crashes like this have to be expected. If the problem only occurs with newer versions of XPrivacy, I think we can assume that it is the culprit. I'm sure that M66B wouldn't do this intentionally so it might be a bug in his hooking framework (on top of Xposed's API). I don't think I can help here, but it might help him if you can reduce the range where the bug has been introduced by testing other intermediate versions one by one.

Oh, skimming over the change list, this might be the reason: https://github.com/M66B/XPrivacy/commit/7bbbe404a7705f223344d05457728691a59e74dc Looks like hooking any constructor will also hook the constructors of the super classes, and Object is always a super class."

Please let me know what additional information I can provide, I am naturally happy to continue testing to help you iron out the problem.

Cheers

M66B commented 10 years ago

I have to think @rovo89 for pointing this out, because this is a major bug and indeed an unintended side effect if the referenced commit.