DavidL0914
commented
9 months ago Individual Review David grading Matthew
- [0.9 - contributed to project with good partcipation] Individual should show that they were key contributor and example to team. This includes their participation in ideas, plans, creating individual issues, providing code commits to project, crossover grading participation, being on task and positive example in the classroom.
Individuals Video, Issue(s), Commits(s)
- [0.85 - Video has a clear demo and explains how to use feature with proper captions. Video is kind of blurry though.] Video in CPT caption style , includes Web demo of key contribution to project, 1 minute
- [0.7 - Good issue showing your plan for your feature but none that shows progress to team objectives. Could also expand on planning issue to be more specific.] Issue(s) that show plans/progress to team objectives
- [0.9 - Good contributions to code with good and often commits] Highlights of key commit(s) in Issues, summarizes code contributions
- [0.9 - Good and frequent commits showing consistent participation throughout the project] Review GitHub analytics for key commits in each weeks during the project, shows consistent participation for 3 weeks
Overall Comments I like the idea behind your feature. I enjoy being able to see the sheep change colors based on different binary values I input, it helps me to visualize how each change to the binary value ends up changing the resulting RGB color. I like the idea of having random trips scroll through below the sheep. I also think it's cool that you added a "Generate Random Color" button.
I gave you a 0.85/0.9 because I like the idea behind your feature and the representation of RGB colors changing with each binary value I input. However, I think the CSS could be better and the page could be formatted neater and easier to navigate. I also think the "tips" bar is scrolling a bit too fast, so I can't finish reading a tip before a new one switches in. I also think you should add an instructions page to explain how RGB color codes work with binary values as well as how to use your feature effectively. I think if you have extra time you can also add some sort of fun feature, like for example you could make the sheep a certain color and then have the user try to input the three binary values for RGB colors to try to match the color of the sheep as closely as possible. Overall though, the idea behind your feature and the way you implement is still pretty good, it's just going above and beyond that you could work on!
Video: Video Key Commits: Making Binary Project More Inuitive and Adding More Aspects for User To Play Around With
Retrospective/Improvements to be made: Overall the CSS could be cleaner, there is an error where the image starts repeating when you scroll down further. Furthermore, the buttons could be easier to navigate and more accessible. Furthermore, I could also make it easier to understand the relationship between binary and RGB colors by creating a button that converts the binary to decimal l. Other than that I would like to expand the project further to truly make it even more above and beyond.