Closed jjfrench closed 10 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
wildintellect commented on 2023-08-31T23:43:09Z ----------------------------------------------------------------
specify that "local" paths must be "buckets"
jjfrench commented on 2023-09-01T19:05:57Z ----------------------------------------------------------------
local "bucket" paths?
It also is referencing the files within the ADE
wildintellect commented on 2023-09-01T20:43:20Z ----------------------------------------------------------------
Yes, I'm trying to clarify that in order for the Mosaic to work via Titiler the files must have an S3 path. This is only true for files in a private-bucket, my-public-bukcet, or shared-buckets path locally.
jjfrench commented on 2023-09-05T14:46:26Z ----------------------------------------------------------------
Does the wording above resolve this? Or I could explicitly state "local private-bucket, my-public-bucket, or shared-buckets paths to their respective AWS S3 prefixes..."
local "bucket" paths?
It also is referencing the files within the ADE
View entire conversation on ReviewNB
Yes, I'm trying to clarify that in order for the Mosaic to work via Titiler the files must have an S3 path. This is only true for files in a private-bucket, my-public-bukcet, or shared-buckets path locally.
View entire conversation on ReviewNB
Does the wording above resolve this? Or I could explicitly state "local private-bucket, my-public-bucket, or shared-buckets paths to their respective AWS S3 prefixes..."
View entire conversation on ReviewNB
@jjfrench Let's ask someone less familiar with how this works to try it.
View / edit / reply to this conversation on ReviewNB
wildintellect commented on 2023-09-07T19:43:07Z ----------------------------------------------------------------
should we upgrade this to use pystac_client? I did submit for that library to be in the default images.
jjfrench commented on 2023-09-07T19:47:03Z ----------------------------------------------------------------
we should, didn't see this - lint made the changes
View / edit / reply to this conversation on ReviewNB
wildintellect commented on 2023-09-07T19:43:08Z ----------------------------------------------------------------
TODO: later replace with stac_ipyleafet?
jjfrench commented on 2023-09-07T21:23:00Z ----------------------------------------------------------------
I had tested using ipyleaflet but it seems to update the map instance in previous cells whereas folium doesn't
Sorry the changes look good but then I realized we're not making use of pystac_client
I had tested using ipyleaflet but it seems to update the map instance in previous cells whereas folium doesn't
View entire conversation on ReviewNB
This is technically for "updating" the ade_mosaic tutorial. It seemed like a duplicate of the SRTM tutorial because they were both creating/displaying MosaicJSONs. The ade_mosaic tutorial was using ipycmc and generating the mosaics from a list of urls, I add the "generating mosaics from a list of urls" bit into the SRTM tutorial and renamed it in the codebase (shown tutorial name is still the same). The ade_mosaic was also applying a colormap to the request so I added that in as well.