New NISAR Notebook - Githubissues

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:25Z ----------------------------------------------------------------

The project team

It is unclear what this means. But I think you can just say "There are a set of sample products

the formate and metadata

_smk0033 commented on 2024-05-09T19:31:42Z_ ----------------------------------------------------------------

I copied that straight from the source, guess I should've read it more in-depth😅 will fix, thanks for pointing that out!

review-notebook-app[bot] commented 1 month ago

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:26Z ----------------------------------------------------------------

Line #1.    !pip install -q h5netcdf

This should also be included in the pangeo image. So we don't need this line.

review-notebook-app[bot] commented 1 month ago

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:27Z ----------------------------------------------------------------

Line #6.        os.mkdir(dataDir)

Instead of this if block you can use os.makedirs with exist_ok=True ref: https://docs.python.org/3/library/os.html#os.makedirs

review-notebook-app[bot] commented 1 month ago

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:28Z ----------------------------------------------------------------

Line #2.    !wget -P {dataDir} {item_asset}

Do we really need to download the dataa? we can't just read it inplace from s3?

_wildintellect commented on 2024-05-16T20:37:36Z_ ----------------------------------------------------------------

Agreed we should not be using WGET, worst case use maap-py to do the download, but really we should be going for an Xarray s3fs direct read.

review-notebook-app[bot] commented 1 month ago

View / edit / reply to this conversation on ReviewNB

jsignell commented on 2024-05-09T19:23:28Z ----------------------------------------------------------------

Replace first sentence with something like:

Finally, let's visualize our data using matplotlib via .plot(). Given what we discovered by inspecting the DataTree above, we know that we are interested in the "HH" group. So when we open the dataset we can specify exactly that group.

Alternatively I bet you could just keep using the datatree object dt that you specified above. It looks like you can probably replace the first line in the cell below with something like:

ds = dt["science/LSAR/GUNW/grids/frequencyA/pixelOffsets/HH"].ds

smk0033 commented 1 month ago

I copied that straight from the source, guess I should've read it more in-depth😅 will fix, thanks for pointing that out!

View entire conversation on ReviewNB

smk0033 commented 1 month ago

Thank you for all of your feedback, Julia! I'll work on getting all of that incorporated!

wildintellect commented 1 month ago

Agreed we should not be using WGET, worst case use maap-py to do the download, but really we should be going for an Xarray s3fs direct read.

View entire conversation on ReviewNB

review-notebook-app[bot] commented 1 month ago

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2024-05-16T20:37:55Z ----------------------------------------------------------------

Change to the GCOV product.

smk0033 commented 1 week ago

@jsignell I think this is ready for another review when you have some time!

smk0033 commented 1 week ago

@nemo794 we would also appreciate your comments on this notebook for the new simulated NISAR data. Thanks in advance!

MAAP-Project / maap-documentation

New NISAR Notebook #401