Closed emmalu closed 10 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This is a very minor comment, but perhaps you should consider renaming the class StacIpyleaflet
to StacMap
. This might aid in clarity as to what it is.
Consider that when using iplyleaflet
, this is conventional:
from ipyleaflet import Map
m = Map()
or
import ipyleaflet
m = ipyleaflet.Map()
Since StacIpyleaflet
is a subclass of Map
(ipyleaflet.Map
), it might aid clarity by naming StacIpyleaflet
to StacMap
so that it better corresponds to the iplyleaflet
conventions. This would then give you this:
from stac_ipyleaflet import StacMap
m = StacMap()
or
import stac_ipyleaflet
m = stac_ipyleaflet.StacMap()
It seems a bit odd to do the following, not only because of the redundancy, but also because it isn't obvious that StacIpyleaflet
is an ipyleaflet.Map
:
from stac_ipyleaflet import StacIpyleaflet
Anyway, just my 2 cents.
Summary:
What did I do? Created a sample notebook that covers how to leverage data from a Pandas Geodataframe as a GeoData layer within stac_ipyleaflet.
Why *** did I do it? (What was the motivation?)
How *** can someone test or demo my changes?
Fixes or Addresses Issue #: #85
Checklist before requesting a review:
HISTORY.rst
)