search

MAAP-Project / user-metadata-form

Questionnaire to get metadata about user-submitted collections
Apache License 2.0
0 stars 0 forks source link

Ab/updates for new flow #28

Closed abarciauskas-bgse closed 2 years ago

abarciauskas-bgse commented 2 years ago

This PR modified the user-metadata-form so that we update or create a Cumulus provider given the users bucket input. Removes job ids which were previously associated with DPS jobs. Adds a test but could add more tests.

chuckwondo commented 2 years ago

Although not part of the changes to the PR, I suggest changing the contents of .ruby-version to drop the ruby- suffix, leaving only the version number (e.g., only 2.7.5, not ruby-2.7.5). Doing so allows use of rbenv in addition to rvm. The ruby- prefix is not acceptable to rbenv, but dropping the suffix works with both rbenv and rvm. Since I have rbenv installed, I'm forced to modify .ruby-version in order to install the correct version.

abarciauskas-bgse commented 2 years ago

Thanks Chuck for the review - I have addressed most of the comments but I agree that the running with docker is not currently working, will try and get that working.