search

MADEAPPS / newton-dynamics

Newton Dynamics is an integrated solution for real time simulation of physics environments.
http://www.newtondynamics.com
Other
936 stars 182 forks source link

Make consistent a MSVC check. #239

Closed 100espressos closed 3 years ago

JulioJerez commented 3 years ago

merged. thanks again.

JulioJerez commented 3 years ago

in this last request there was a bug in this line target_compile_options(${projectName} PUBLIC $<$:$<$:/wd4201>>>)

wit that original line it add the option '>' to the additional option in visual studio, but that produces a compiler error. I assume you meant this

target_compile_options(${projectName} PUBLIC $<$:$<$:/wd4201>>)

afte doing that, is does actually do anythong, since that disabled warning is inherited from the master cmake. by I am guessing that when using wit other project is does add that warning.

anyway I edited it a commited the change. please see if that was what you meant.

100espressos commented 3 years ago

Thanks for the correction.