MAECProject / schemas

MAEC Schemas and Schema Development
84 stars 16 forks source link

Field static_features has wrong structure #139

Closed sergeymetallic closed 6 years ago

sergeymetallic commented 6 years ago

In the malware-instance.json https://github.com/MAECProject/schemas/blob/master/malware-instance.json#L68 there is a property definition:

"static_features":{
                    "items": {"$ref": "static-features.json#/definitions/static-features"},
                    "description": "Captures features associated with the binary that aren’t related to the semantics of the code (e.g., strings, packer information). Note that StaticFeaturesType captures multiple static features."
                }
}

There should be either "type":"array" or just a $ref in the root

gtback commented 6 years ago

Thanks, @sergeymetallic . Looks like this might have just been a copy-paste error. I think it should be:

"static_features":{
  "$ref": "static-features.json#/definitions/static-features",
  "description": "Captures features associated with the binary that aren’t related to the semantics of the code (e.g., strings, packer information). Note that StaticFeaturesType captures multiple static features."
},
elegantmoose commented 6 years ago

@sergeymetallic, changed to syntax suggested by @gtback, good?

sergeymetallic commented 6 years ago

@mbastian1135 , thanks!