MAFINS / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-pc-sp
GNU General Public License v3.0
766 stars 487 forks source link

[FiveM] Object spawning was broken in a recent update. #244

Open ReadyP1ayerTwo opened 3 years ago

ReadyP1ayerTwo commented 3 years ago

On FiveM, When i spawn an object it spawns 10-30 copies of the object i spawned, along with a few random objects. The same thing goes for peds, or any other spawnable object. I've tried this in two servers, and i still have the same issue.

Not sure if you offer any support whatsoever for FiveM; But i figure it's worth a mention here anyways. I really hope this mod continues to work in FiveM because it brings me back to the good old days of modding in GTA:O.. except with this mod on FiveM you don't have to worry about being banned.

ReadyP1ayerTwo commented 3 years ago

would be cool if we could get an official FiveM fork for this menu with various bug fixes for FiveM. Doubtful to see it happen. I'd do it myself, but i have no idea what the hell i'm doing. closest ive gotten to doing anything is opening the .sln file in visual studio and scrolling through and looking at shit.

ReadyP1ayerTwo commented 3 years ago

Here's a reply i got from one of the FiveM devs. This may be useful for anyone trying to figure this out.

deterministic_bubble, Cfx.re Team

if it ‘depends’ on ‘being placed in the cache directory’, that’s nothing in FiveM code that makes it ask for such. That’s 100% code in ‘Menyoo’ having weird path handling.

I’d suspect it expects to be ‘placed in the cache folder’ as it wants to be one directory up from what it thinks is the game EXE. Maybe not even. If the cache directory gets renamed or moved, and you worked around some incompatibility in a third-party mod by moving something into the cache directory, you don’t blame ‘the update’, you blame the incompatibility and/or try moving the directory wherever else it should go.

look at this code. Some overcomplicated trash to get a path for a directory. It’s super bad C++ too

https://github.com/MAFINS/MenyooSP/blob/b216d9448450a3832f8ef892c1827603ad55ea5a/Solution/source/Util/ExePath.cpp