MAFINS / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-pc-sp
GNU General Public License v3.0
775 stars 492 forks source link

Menyoo Customs: Bike wheels are not being saved properly #447

Closed metoxys closed 1 year ago

metoxys commented 1 year ago

Reproduce: Customize bike, select different rims for front and rear wheel, save bike to file, spawn saved bike from file

Rim selected for the front wheel is on the rear wheel as well

metoxys commented 1 year ago

Just for additional info, I am sure that this is a bug about saving bike wheels and not spawning them, because bikes I saved in earlier versions of Menyoo spawned fine with different rims

itsjustcurtis commented 1 year ago

Entirely possible, recent changes to the save vehicle script may have messed with that slightly

metoxys commented 1 year ago

Entirely possible, recent changes to the save vehicle script may have messed with that slightly

If it helps, according to my notes, in previous Menyoo versions, ID 23 is front rim, ID 24 is rear rim
EDIT: My hypothesis is that front wheel ID is being saved as both 23 and 24

metoxys commented 1 year ago

image @itsjustcurtis Now, when customizing bike rear wheels, I can change the rim by pressing Enter, but the icon confirming which rim is on there is not changing when LSC style is turned off
Also the saving is not working just as before

itsjustcurtis commented 1 year ago

I've come across this before, I think its an issue with how the menu is rendered. The saving of wheels is separate, I'll have a look at whats going on

itsjustcurtis commented 1 year ago

image

Looking at the wheel indexes, the list actually skips a number of indexes, making it almost impossible to get the marker to show properly. This is going to take a lot of effort to make work properly by the looks of things.

metoxys commented 1 year ago

Maybe my hardcoded wheel id list idea is not so crazy after all
Could be worth a shot, especially if it's only executed when an untampered wheel list is used