Some potential mod shop navigation fixes

[MAFINS]

• Possible solution to #424 ?

@itsjustcurtis please do take a look and test this when possible. I found some of the uses of the selected option numbers instead of the mod/wheel/paint ids passed to the functions already rather confusing and unnecessary.

[MAFINS]

Further changes made to make menu stay in car mod submenu after applying mod. Los Santos Customs does not hop the user back when purchasing or equipping a car mod.

[itsjustcurtis]

I can certainly have a look, however I have made some fairly significant changes in my own fork that may conflict with this. Looking at it, my main concern is the removal of the setwheel/setpaint/setmod function. Without those markers the script went haywire and would continuously apply the selected mod after going back. I always thought LSC took you back a menu, its been so long since I used it though! Removing that function would save a lot of headaches in the script.

[MAFINS]

@itsjustcurtis See latest commit to reduce the looped application of the paint/mod/wheel

[MAFINS]

@metoxys You may want to check if bfca41c does fix the indicator for the equipped bike rim, etc. that you mentioned in https://github.com/MAFINS/MenyooSP/issues/447#issuecomment-1363837178

[metoxys]

Okay, I tested it @MAFINS @itsjustcurtis

When LSC style is off, it works flawlessly
When LSC style is on, the bike wheel menus don't seem to do anything as you scroll and press Enter

[itsjustcurtis]

Echoing what Metoxys has said, wheels menu is completely un-functional atm. Paints and Mod parts are working as expected. Going to merge changes from my most recent commits into this and add to my own fork

[itsjustcurtis]

Very simple fix

bool allowSettingWheelPreview = GET_VEHICLE_WHEEL_TYPE(vehicle) != wheelType || (wheelType == WheelType::BikeWheels && isBikeBack ? GET_VEHICLE_MOD(vehicle, VehicleMod::BackWheels) != wheelIndex : GET_VEHICLE_MOD(vehicle, VehicleMod::FrontWheels) != wheelIndex);

in the second half of the OR comparision, the script should check that the current wheels are NOT the same as the wheelIndex. swapping the two == for != fixes this issue.

[MAFINS]

@itsjustcurtis There seem to be some build errors in 33447c4 but if it's actually fine (or can become fine), just make a pull request. A that point, I'll add your fork as a remote and merge your changes with some other things, and increment the version number before pushing a release.

[itsjustcurtis]

Yeah there's some minor bugs I still need to address, but I had to get to bed! I'll send a new pull when I'm happy with the build

Kind regards

Curtis Elliott

On Mon, 26 Dec 2022, 08:53 MAFINS, @.***> wrote:

@itsjustcurtis https://github.com/itsjustcurtis There seem to be some build errors in 33447c4 https://github.com/MAFINS/MenyooSP/commit/33447c4444ea7d5c55b1170495931f3a3a005985 but if it's actually fine (or can become fine), just make a pull request. A that point, I'll add your fork as a remote and merge your changes with some other things, and increment the version number before pushing a release.

— Reply to this email directly, view it on GitHub https://github.com/MAFINS/MenyooSP/pull/451#issuecomment-1365008817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZPAVUXTMCBZSDI6ZMFG73WPFMKHANCNFSM6AAAAAATI63J54 . You are receiving this because you were mentioned.Message ID: @.***>