[Bug] HasSiren detection detects Mule has a siren

WithLithum commented 1 year ago

Screenshot

Description

HasSiren method that was used to resolve the issue #436 works incorrectly and presumably detected an incorrect bone which caused most vehicles do not have Siren features even if they were supported before the commit dfdf278e.

Excepted behaviour

Only vehicles that has siren1 will have Siren options support.

Actual behaviour

A weird set vehicles (some do have siren, some do not) have siren options support regardless of whether or not they actually have siren.

Workarounds

Enable siren manually by getting into the vehicle, then press Horn (default E) to enable/disable siren, before putting any peds into it.
Soul-steal the driver (the driver has to be in the Object Spooner Database) and manually enable/disable siren before soul-stealing back to the player.

Notes

It is possible that something is wrong with VBone::siren1 (for example, pointing to a completely different bone) that caused the detection to go wrong.
siren1 do show up in the bone list of the attachment menu (of vehicles that do have such bone).

metoxys commented 1 year ago

It also detects the BR8 has a siren (maybe other open wheelers as well)

itsjustcurtis commented 1 year ago

Looking into this, it looks like the vehicle bone list is out-dated. That said, using the latest bone list appears to remove the option for all vehicles. Looking into it, menyoo does dynamically look up bone indexes based on the name, so I'm not sure where its failing here

MAFINS commented 1 year ago

Well for some reason the enum VBone::VBone and the string array VBone::vNames are completely different in order. One or the other needs re-ordering.

itsjustcurtis commented 1 year ago

I'm doing some unrelated changes at the moment, can easily do that while I'm in here and test

On Fri, 20 Jan 2023, 19:25 MAFINS, @.***> wrote:

Well for some reason the enum VBone::VBone and the string array VBone::vNames are completely different in order. One or the other needs re-ordering.

— Reply to this email directly, view it on GitHub https://github.com/MAFINS/MenyooSP/issues/486#issuecomment-1398834144, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZPAVQXDCYBH6BDPLEAZTLWTLRCXANCNFSM6AAAAAAUABLNUM . You are receiving this because you commented.Message ID: @.***>

MAFINS / MenyooSP