MAFINS / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-pc-sp
GNU General Public License v3.0
771 stars 491 forks source link

Incorrect vehicle max speed #524

Open TheFlash3113 opened 1 year ago

TheFlash3113 commented 1 year ago

I have a handling mod (handling.meta) installed in the mods folder. Works perfectly without Menyoo.

With Menyoo the top speed of cars entered is incorrect. In my handling.meta, Adder is set to 407 km/h. But under vehicle options in Menyoo it says 182. Definitely not ideal. A fix would be amazing.

Is Menyoo actually getting the top speeds of vehicles from somewhere?

nomakewan commented 1 year ago

The max speed is determined by using a native called GET_VEHICLE_MODEL_ESTIMATED_MAX_SPEED(vehicle model hash).

Please see the code here: https://github.com/MAFINS/MenyooSP/blob/master/Solution/source/Submenus/VehicleModShop.cpp#L1776

Since it's getting the estimated maximum speed of the vehicle model and not the actual maximum speed, that is likely where the discrepancy lies.

EDIT: Also note that that native returns a value in meters/second, not kilometers/hour or miles/hour. 182 m/s would be 655.2 km/h.