MAFINS / MenyooSP

[or Menyoo PC] - Trainer/mod menu for Grand Theft Auto V (single-player).
https://www.gta5-mods.com/scripts/menyoo-pc-sp
GNU General Public License v3.0
766 stars 487 forks source link

MP model facial makeup color bug #647

Open CJdaMan opened 6 months ago

CJdaMan commented 6 months ago

This is manly adressed to @The-UnXplained, who seems to be the guy really interested in keeping this trainer up to date.

I've noticed many people have had this issue since the "feature" of applying a color overlay into the MP face makeup was, unfortunately, introduced in Menyoo. I made a topic myself but didn't include videos at the time, so here they are.

This is a video that shows the issue: as you can see, every facial makeup option is totally black, since the trainer is applying a color overlay that cannot be turned off (white option turns all the layer white), so it messes up how makeup is supposed to look:

https://github.com/MAFINS/MenyooSP/assets/149864606/367fcdd3-821a-4a69-93aa-a38178f6f6b4

CJdaMan commented 6 months ago

And, as you can see here, in the latest version WITHOUT that added "feature" (1.75, I believe), the layers show their correct color since there's no uneeded coloring over it.

I'm asking you to please fix it if you can with an option to have no color overlay applied or, if that can't be done, to remove that "feature".

Sorry for the insistence, but this is an unfortunate bug for the best trainer available.

https://github.com/MAFINS/MenyooSP/assets/149864606/ee951c6a-706f-4060-9c4a-6aad68043853

ghost commented 6 months ago

Untitled

Thanks for the video, much appreciated! Can you test my latest version https://github.com/MAFINS/MenyooSP/issues/648 and let me know if you still have this issue please because the makeup's all seem to be working fine for me..

CJdaMan commented 6 months ago

Untitled

Thanks for the video, much appreciated! Can you test my latest version #648 and let me know if you still have this issue please because the makeup's all seem to be working fine for me..

Thanks for the answer. Unfortunately, the mentioned bug happens in your version. The video of it was taken using your asi file. I just tried again downloading from the link you provided and it persists.

I'm up to date and can load any asi mod without problems, so I don't think it's a setup issue and, as you can see in the issues of this repository, I'm not the only one. Maybe it could be possible to add a toggle to activate/disable the feature in the trainer or have a version without it?

Thanks!

ghost commented 6 months ago

ok, if i get time later i will just remove the 'makeup color modifier'. Also got a few bits and bobs to add aswell that i completely forgot about..

CJdaMan commented 6 months ago

ok, if i get time later i will just remove the 'makeup color modifier'. Also got a few bits and bobs to add aswell that i completely forgot about..

Thanks for your efforts. And don't mind the people that insult you, some of us appreciate the up-to-date trainer.

ghost commented 6 months ago

Untitled

Test this: Test Build.zip

CJdaMan commented 6 months ago

Untitled

Test this: Test Build.zip

Perfect! Now the makeup works as intended.

CJdaMan commented 6 months ago

ok, if i get time later i will just remove the 'makeup color modifier'. Also got a few bits and bobs to add aswell that i completely forgot about..

Will this fix be integrated in your next general version? So I'll keep an eye for your sucesive updates.

ghost commented 6 months ago

Yes buddy, it will remain commented out unless i or someone else in the future can be bothered to put something in to enable / disable it at some point. A small update will be released later today or tomorrow at the latest.

ghost commented 6 months ago

wow, you found some video from like 2 years ago of someone trying report me online.. and two very old banned accounts on the shitty 5mods site.. whats your point..? ps, who the fuck is Philip.. lol

CJdaMan commented 6 months ago

Yes buddy, it will remain commented out unless i or someone else in the future can be bothered to put something in to enable / disable it at some point. A small update will be released later today or tomorrow at the latest.

fcn sad modder https://www.youtube.com/watch?v=GPeXcrxBwqM

Hey, man, what's your problem? I see you looking to argue with him every time.

Do you have proof that his version of Menyoo has malicious code? I'm not a modder, but I can say my CPU/GPU usage is identical when I use his version and that my AV finds the file as a safe one.

Also, he is solving issues of the trainer when it has been almost a year since the last "official" update of the repository.

ghost commented 6 months ago

The reson they put that on the 5mods site is because i was posting download links from my mediafire account that their system (bult in av scanner) can't check. Reyser & unkownmodder (alloc8or?) are very friendly with mafins hence why even with proof of things mafins said to me way back in like 2019 they wouldn't let me upload the files on their site.

I have, in the past uploaded the source code to my own profile on here but removed it a few days late because it quickly attracted this twat who started spamming me with his gibberish nonsense and also because of various other reasons.

However, now things seem to be changing in a different direction on here with mafins seemly gone for good this time i am considering re-uploading the source code to my profile again at some point in the near future but first i need to get a bit more clued-up on how github works and find ways to block access to the repository to known idiots such as him.

In the meantime, if anyone doesn't trust any version(s) posted by me then don't download them. It's as simple as that.

mistahwolf commented 5 months ago

@ghost, That last update cleared up the makeup issue. Thanks for that. Still have that issue with the 'teleport markers' only letting you use them when in a vehicle and working only at the start of gameplay when on foot. That and the inconsistent 'max' number of props to be used when doing builds. I saw 'justcurtis' released his version of Menyoo, so hopefully between you and him this mess will get fixed. In the meantime, thanks for continuing to hammer away at this old (but great) mod.

SkyK0T commented 5 months ago

he didn't fix this problem, he deleted one line, he is nothing of the sort, and only builds himself up to be smart, which he is not