search

MAIF / izanami

Izanami is a centralized versatile feature flag solution, well suited for micro service architectures.
https://maif.github.io/izanami/
Apache License 2.0
189 stars 43 forks source link

make scopes configurable in V2 #827

Closed keltakmaster closed 5 months ago

keltakmaster commented 5 months ago

Hi!

Would it be possible to make openid scopes configurable for izanami v2?

Right now, scopes are hardcoded as "scope=openid%20profile%20email%20name".

Passing the "name" scope in unusual as it is not part of the openID standards, it's a claim usually available in the "profile" scope.

As a result, users must define a new scope "name" in their OIDC provider.

ptitFicus commented 5 months ago

Hi,

Thanks for the issue, I'll look into it, but I don't think it'll be an issue to make this configurable.

ptitFicus commented 5 months ago

Hi @keltakmaster,

This should be fixed in 2.2.0, that was released just now.

Scopes are now configurable, moreover you can specify which element of the id token will be used as username and email on izanami's side.

More details here please let me know if you are missing something else on OIDC.

keltakmaster commented 5 months ago

That's very kind of you! I will try that tomorrow and let you know if everything is OK !

keltakmaster commented 5 months ago

Hi @ptitFicus,

Everything works as intended regarding OIDC, many thanks!