MAIF / shapash

🔅 Shapash: User-friendly Explainability and Interpretability to Develop Reliable and Transparent Machine Learning Models
https://maif.github.io/shapash/
Apache License 2.0
2.71k stars 330 forks source link

Loosen requirements strictness #292

Open quassy opened 2 years ago

quassy commented 2 years ago

Currently setup.py is very strict on some requirements (and quite loose on others). This will make installing shapash in combination with other packages difficult as it can lead to incompatible versions. I think all == should be safe to replace with ~= as point releases are generally compatible (and it might make sense to specify a minimum scikit-learn version):

        'plotly==4.12.0',
        'matplotlib>=3.3.0',
        'numpy>1.18.0',
        'pandas>1.0.2',
        'shap>=0.36.0',
        'dash==1.17.0',
        'dash-bootstrap-components==0.9.1',
        'dash-core-components==1.13.0',
        'dash-daq==0.5.0',
        'dash-html-components==1.1.1',
        'dash-renderer==1.8.3',
        'dash-table==4.11.0',
        'nbformat>4.2.0',
        'numba==0.53.1',
        'scikit-learn'
ThomasBouche commented 2 years ago

Thank you for the issue. We agree that we need to specify a minimum version and have less strict requirements. We will work in the next weeks or months on code refactoring and dependencies management. We will take into account your proposals or you can also propose a pull request