MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Subdomain-specific website themes #355

Closed ddabble closed 2 years ago

ddabble commented 3 years ago

Depends on #354, and should change base to dev after that PR has been merged.

Highlights:

codecov[bot] commented 3 years ago

Codecov Report

Merging #355 (699f13a) into dev (36be120) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #355      +/-   ##
==========================================
+ Coverage   82.72%   82.84%   +0.12%     
==========================================
  Files         117      118       +1     
  Lines        4161     4192      +31     
==========================================
+ Hits         3442     3473      +31     
  Misses        719      719              
Impacted Files Coverage Ξ”
web/static.py 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 36be120...699f13a. Read the comment docs.

ddabble commented 2 years ago

I dissagree with the favicons, the backgrounds makes it more difficult to see the logo, especially the main one (the one with white background).

That's fair πŸ˜… I added the changes we discussed in 51f6c8487157f3f6f37153e4a1d225f64b16d939 πŸ™‚

One solution (that i would suggest) is to have the same favicon for all subdomains (a transparent one).

Another solution is to have the main one be transparent and the rest of the subdomains as the different colored ones

Just to reiterate what came out of our discussion, having a transparent favicon should ideally be avoided, as the logo becomes hard to see if the tabs of a user's browser has e.g. a light/yellow background color (at least as long as the favicon doesn't have its own border to make it easier to discern the logo from any background color), and so the solution added in the commit mentioned above seems better.

@sigtheidiot Could you try seeing how the favicons look now? 😊

ddabble commented 2 years ago

Btw, the tests should succeed after #400 has been merged πŸ™‚

ddabble commented 2 years ago

(although you forgot the docs domain but I don't mind since nobody uses it)

Yeah, I left it out, since the subdomain is a work in progress (according to the last developer who was working on it), and because I kinda couldn't be bothered finding/making yet another variation of the logo πŸ˜… Also, I thought of the docs as kind of being part of the main site, since they're both public - unlike the internal and admin domains, which both require special permissions to visit πŸ™‚

ddabble commented 2 years ago

@sigtheidiot Alright, I can wait for you to have time to check it out, before merging, if you want 😊

sigridge commented 2 years ago

@ddabble Checked them out in browser now. The rounded corners really make a difference and I think they look really good ❀️