Template refactorization + internal home page + model history

[ddabble]

Depends on #358, and should change base to dev after that PR has been merged.

Main highlights

• Refactored most edit forms to use same template (1ebbf97f62b43fd7aa342c58876c3124045cea5c)
  • Made contentbox/edit.html extend the generic one (bbd6fa9271a81f2915ba23a82a1d25b4dec3ad45)
• Made ContentBox subdomain-agnostic (5c0e6a2b96777d93205b8d08cb45cc47f0b26aa1)
• Made the internal home page a content box (880a6cb9ef7d6633e051bc0de30d19ca916fe3b9) that allows editing the HTML source code (9156202b6ae9f6fd2312ff07f6f20af04d7d114d) and that only uses Norwegian (4ad67b746320bff1fa96ece77be22250f18af006)
• Added bleaching of content boxes (39b640a578a77c4f12f480cdb9a40cc3635425a7)
• Enabled content boxes requiring extra permissions to modify them, through the field extra_change_permissions (4a0348fdb457a105ad32e6e9aa61a6725c877e2e)
• Added django-simple-history for some models (fa62d9fda26c17950b073f7e95f239efde098165)
  • This adds history tracking to the ContentBox, Question, Committee, Secret, MachineUsageRule, Event and Article models
  • Site admins can view this history through the Django admin page for each model object, and have the option to revert the object to a specific historic version
• Improved layout of the CKEditor toolbar (68012913c03308871d3a2897591a46e9ae2ac182)

Additional highlight

• Refactored ReservationRule.start_days (516cf75a0ea695a9fd65e34f12d5c4d4497a19bd)
• Moved ReservationRule validation to form (1bfa14cd2b5c614af726dbbbdb735726eab5efc9)
• Renamed Content.changed -> last_modified (25afa8283a5e0702e8efb0392a2f1aeca1b6b3fd)
• Added some fields to the Django admin page for system accesses (dd68be1c04bb2714f651901397c1265793145aad)
• Added tests for all Django admin GET endpoints (5060e706c240c377b4d0675b6817d5e7581b68bb)

[codecov[bot]]

Codecov Report

Merging #359 (94ca09c) into dev (c7a25b5) will increase coverage by 4.05%. The diff coverage is 94.64%.

@@            Coverage Diff             @@
##              dev     #359      +/-   ##
==========================================
+ Coverage   83.15%   87.21%   +4.05%     
==========================================
  Files         124      128       +4     
  Lines        4357     4801     +444     
==========================================
+ Hits         3623     4187     +564     
+ Misses        734      614     -120     

Impacted Files	Coverage Δ
make_queue/views/api/reservation.py	100.00% <ø> (ø)
web/views.py	96.77% <ø> (-0.11%)	:arrow_down:
docs/forms.py	59.09% <36.84%> (-18.69%)	:arrow_down:
make_queue/forms.py	86.95% <78.04%> (+5.13%)	:arrow_up:
docs/views.py	85.34% <80.00%> (+6.09%)	:arrow_up:
util/auth_utils.py	88.00% <87.50%> (-12.00%)	:arrow_down:
web/widgets.py	94.16% <88.88%> (-4.32%)	:arrow_down:
util/view_utils.py	90.66% <90.27%> (-9.34%)	:arrow_down:
internal/views.py	89.54% <98.48%> (+4.08%)	:arrow_up:
announcements/views.py	100.00% <100.00%> (ø)
... and 64 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7a25b5...94ca09c. Read the comment docs.

[ddabble]

@Maisergodt

• When editing existing content boxes on the main page, the English section is gone.

Yes, that's on purpose (see 4ad67b746320bff1fa96ece77be22250f18af006), as it removes the hassle of translating all of the text and copying code from one language to the other 😊 Besides, all members are required to be able understand written Norwegian anyway 😅 EDIT: I read too quickly, and realize now that you said "on the main page", and what I was talking about above was for the internal home content box 😅 But this makes things even more weird than what I mentioned below, as only the internal home content box should have one language - all the other content boxes should not have changed, and neither the tests nor my local test server show that this is not the case 😮 Has maybe something unusual happened to your local code or database, or should we try to reproduce the discrepancy on more machines? 🤔

• Additionally when trying to save a content box, an error message is raised. The same behavior goes for the content box on the internal page as well.

Hm, that's weird, as I've written tests that explicitly test this case for the internal home content box (see internal/tests/test_views.py), and I'm unable to reproduce the error you're getting (even when manually clearing the value of both languages in my local database, which I thought could be the cause) 🤔

[Maisergodt]

@ddabble

Hm, that's weird, as I've written tests that explicitly test this case for the internal home content box (see internal/tests/test_views.py), and I'm unable to reproduce the error you're getting (even when manually clearing the value of both languages in my local database, which I thought could be the cause) 🤔

The tests for internal content box are working, I spoke to quickly. It does indeed work for the content box on the internal page as intended, but the bugs on the main page still holds.

Has maybe something unusual happened to your local code or database, or should we try to reproduce the discrepancy on more machines?

I can debug it thoroughly later today/this weekend and spot if anything is unusual on my end. It does not hurt if other members could test it as well 👀

[ddabble]

@Maisergodt I'm fairly positive that it's been fixed now, would you mind testing again? 😊