MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.

https://makentnu.no

MIT License

9 stars 5 forks source link

Make fonts self-hosted #409

Closed ddabble closed 2 years ago

ddabble commented 2 years ago

This makes us self-host the Ubuntu font that we're using (b72011d8789a6e1da9428367be7a658c8ebc13cf), and adds a math formula button to CKEditor with also adds some additional self-hosted fonts for rendering the math formulas (bd613e230e5fd45bea91eee2181b7f1ff94ddbea and 058cf850aaf92910b0da85dba8a2d339d2176010).

codecov[bot] commented 2 years ago

Codecov Report

Merging #409 (058cf85) into dev (a1ead75) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #409   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         136      136           
  Lines        5142     5142           
=======================================
  Hits         4496     4496           
  Misses        646      646

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1ead75...058cf85. Read the comment docs.

ddabble commented 2 years ago

@maritmoe Excellent, thank you for figuring out a solution, and for that code snippet! 😄 I implemented it in 058cf850aaf92910b0da85dba8a2d339d2176010 (but with locally hosted scripts 😋).

I tried to make a commit with the change I did. I do not know if it is okay to do it like i did.

Do you mean that you made a commit locally, but did not push it yet..? If so, did it contain any additional improvements compared to the implementation in 058cf850aaf92910b0da85dba8a2d339d2176010? 🙂

In any case, if the functionality and the code now looks good, would you mind leaving an approval review? 😊