MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Secrets only use one language #457

Closed ddabble closed 2 years ago

ddabble commented 2 years ago

Proposed changes

Secrets now only use one language, for the same reason that the internal home content box only uses one language - namely that it's less of a hassle to fill in one instead of two languages, and that all MAKE members are required to be able to understand written Norwegian. Also, several secrets on the live site either had their Norwegian contents copied to the English contents, or they only had Norwegian content with the English content simply saying to see the Norwegian page.

Some additional improvements:

Areas to review closely

None in particular.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 2 years ago

Codecov Report

Merging #457 (4c52315) into dev (17766a9) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #457   +/-   ##
=======================================
  Coverage   87.95%   87.95%           
=======================================
  Files         134      134           
  Lines        5388     5390    +2     
=======================================
+ Hits         4739     4741    +2     
  Misses        649      649           
Impacted Files Coverage Δ
contentbox/forms.py 100.00% <100.00%> (ø)
contentbox/views.py 100.00% <100.00%> (ø)
internal/models.py 93.19% <100.00%> (ø)
web/multilingual/admin.py 91.66% <100.00%> (+0.36%) :arrow_up:
web/multilingual/data_structures.py 95.45% <100.00%> (ø)
web/multilingual/formfields.py 94.33% <100.00%> (ø)
web/multilingual/modelfields.py 100.00% <100.00%> (ø)
web/multilingual/widgets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17766a9...4c52315. Read the comment docs.