MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Cleanup of some templates #459

Closed ddabble closed 2 years ago

ddabble commented 2 years ago

Proposed changes

Areas to review closely

The sub-templates that are included by event_detail.html and whether they produce the same output as before the refactoring.

Also, it might be useful to go through each commit separately instead of looking at the PR's "Files changed" summary, due to the renaming and large refactoring of files.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 2 years ago

Codecov Report

Merging #459 (d2b847b) into dev (2f5a9f8) will decrease coverage by 0.00%. The diff coverage is 95.00%.

@@            Coverage Diff             @@
##              dev     #459      +/-   ##
==========================================
- Coverage   87.95%   87.95%   -0.01%     
==========================================
  Files         134      134              
  Lines        5390     5389       -1     
==========================================
- Hits         4741     4740       -1     
  Misses        649      649              
Impacted Files Coverage Δ
util/templatetags/css_tags.py 100.00% <ø> (ø)
make_queue/templatetags/reservation_extra.py 90.69% <50.00%> (ø)
news/views.py 91.37% <100.00%> (ø)
util/locale_utils.py 96.22% <100.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f5a9f8...d2b847b. Read the comment docs.