MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Internal "bulletin board" content boxes for each committee #460

Closed ddabble closed 2 years ago

ddabble commented 2 years ago

Proposed changes

Added "bulletin board" content boxes for each committee on the internal site. These can e.g. contain notices, instructions, and links to common resources, and can act as a "hub" for each committee.

Also added a new navigation menu just below the title of the internal home page, which is used to navigate between the committee boards and the home page.

Areas to review closely

The new navigation menu is a little bit different from other things on the website, so it would be nice to get some feedback on whether it still fits or should be changed 🙂

Deployment notes

The dev-board content box should have the internal.can_change_rich_text_source permission, so that it's possible to change the rich text source code directly.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 2 years ago

Codecov Report

Merging #460 (86c421b) into dev (54bb962) will increase coverage by 0.01%. The diff coverage is 90.47%.

@@            Coverage Diff             @@
##              dev     #460      +/-   ##
==========================================
+ Coverage   88.04%   88.05%   +0.01%     
==========================================
  Files         134      134              
  Lines        5436     5449      +13     
==========================================
+ Hits         4786     4798      +12     
- Misses        650      651       +1     
Impacted Files Coverage Δ
internal/templatetags/member.py 89.18% <88.88%> (-2.48%) :arrow_down:
internal/urls.py 100.00% <100.00%> (ø)
internal/views.py 89.67% <100.00%> (+0.11%) :arrow_up:
checkin/views.py 43.45% <0.00%> (-0.34%) :arrow_down:
checkin/local_scanner.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54bb962...86c421b. Read the comment docs.

ddabble commented 2 years ago

Maybe rename "forside" to MAKE?

Ooh yeah, I agree, that would make it more clear 👌