ddabble commented 2 years ago

Proposed changes

New features

Added a URL which always links to the current week for a machine reservation calendar
- This URL can be copied by right-clicking the "View in calendar" button for a machine on the machine list page, and selecting "Copy link address"

Improvements

Loading the member list has been made slightly faster
Renamed a lot of templates (and CSS and JavaScript files) to comply with the style guide
Improved word breaking (splitting a word between two lines, often using a hyphen) multiple places, like in titles and descriptions
Added translations to the spreadsheet containing course registrations, that can be downloaded from the course registrations page
Improved the permission check for the admin panel
On the history page for a documentation page (on docs.makentnu.no), the current version link is now a permalink to that specific version

Fixes

Fixed endless redirect loop when a logged-in user visited a page that required a permission that the user didn't have
Fixed error messages for multilingual form fields (like the event "Content" field) not showing
Previously, editing CKEditor fields (like the event "Content" field) did not prevent the user from leaving the page; this has now been fixed
Fixed old page version warning when visiting the URL for a specific documentation page version which is the current version of that page

Other changes

Added setup instructions to the project's README file
Much code cleanup, yes (mainly a95888086a4f4080839fedc83ffd1ddf98a63cb8)

Areas to review closely

Nothing in particular.

Deployment notes

Can manually delete the now "unregistered" make_queue.can_edit_quota permission.

Checklist

(If any of the points are not relevant, mark them as checked)

[x] Created tests that fail without the changes, if relevant/possible
[x] Made sure that your code conforms to the code style guides and that any common code smells have been addressed
- (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
[x] Added sufficient documentation - e.g. as docstrings or in the README, if suitable
[x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
[x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server

codecov[bot] commented 2 years ago

Codecov Report

Merging #476 (0b5352a) into dev (8f52dea) will increase coverage by 0.08%. The diff coverage is 85.57%.

@@            Coverage Diff             @@
##              dev     #476      +/-   ##
==========================================
+ Coverage   88.03%   88.12%   +0.08%     
==========================================
  Files         134      133       -1     
  Lines        5451     5531      +80     
==========================================
+ Hits         4799     4874      +75     
- Misses        652      657       +5

Impacted Files	Coverage Δ
checkin/urls.py	`100.00% <ø> (ø)`
internal/forms.py	`86.91% <ø> (ø)`
internal/signals.py	`42.85% <0.00%> (ø)`
mail/email.py	`36.58% <0.00%> (-2.06%)`	:arrow_down:
make_queue/forms.py	`87.71% <ø> (ø)`
make_queue/views/api/calendar.py	`97.61% <ø> (-0.06%)`	:arrow_down:
users/models.py	`94.28% <ø> (ø)`
util/templatetags/form_tags.py	`100.00% <ø> (ø)`
contentbox/models.py	`78.78% <30.00%> (-21.22%)`	:arrow_down:
news/forms.py	`94.28% <40.00%> (-2.78%)`	:arrow_down:
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f52dea...0b5352a. Read the comment docs.