Improve misc. things

[ddabble]

Proposed changes

Improvements

• Place files uploaded through CKEditor in a separate folder for each model (318d5f337f76b87d7a82c755f4ca44519d17464e)
• Made all pages have a consistent (browser tab) title format (26774157d0a10bd6445b0b9d9c7e0f6cccfa67e3)
  • Most pages will have " | MAKE NTNU" as suffix to the title; subpages of the admin panel have " | Admin panel | MAKE NTNU" as suffix
• Replaced the trans template tag with translate (46a81ff2162cb1ed98643d03e6677053a5e073c7)
• Made the user field of Profile non-nullable (4dc7dff842ad30dde2d12e009ba713f149cddd36)
• Added "and employees" to the end of the Open Graph description (398d0c96333c873764f6cf887879cb97b3214bbf)
  • This is shown in some search engines and when embedding pages from the website on sites like Facebook

Fixes

• Made the CKEditor file uploader work on all subdomains (0a03254e3be8bab11bc5283305d65e769cc4d42d)

Other changes

• Never-ending masses of code cleanup (0a1e4f811578657a928b31847e2186005f82dab8 + some other commits)

Areas to review closely

Ensure that all pages have a (sensibly) set title (through the <title> tag).

Deployment notes

The base folder for all uploaded CKEditor files was changed from ckeditor-upload to ckeditor_upload, so the existing folder on the server should be manually renamed while deploying. All references to files in that folder (only in inserted images in rich text fields, like those of articles and ContentBoxes) must also be updated - either manually on the website, or through the Django shell on the server.

Checklist

(If any of the points are not relevant, mark them as checked)

• [x] Created tests that fail without the changes, if relevant/possible
• [x] Made sure that your code conforms to the code style guides and that any common code smells have been addressed
  • (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
• [x] Added sufficient documentation - e.g. as docstrings or in the README, if suitable
• [x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
• [x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server

[codecov[bot]]

Codecov Report

Merging #569 (7f0540c) into dev (6333885) will decrease coverage by 0.70%. The diff coverage is 46.66%.

@@            Coverage Diff             @@
##              dev     #569      +/-   ##
==========================================
- Coverage   88.46%   87.76%   -0.71%     
==========================================
  Files         132      133       +1     
  Lines        5514     5572      +58     
==========================================
+ Hits         4878     4890      +12     
- Misses        636      682      +46     

Impacted Files	Coverage Δ
internal/models.py	93.28% <ø> (ø)
makerspace/models.py	100.00% <ø> (ø)
news/models.py	98.69% <ø> (ø)
util/ckeditor_utils.py	0.00% <0.00%> (ø)
util/templatetags/string_tags.py	100.00% <ø> (ø)
web/hosts.py	100.00% <ø> (ø)
util/locale_utils.py	82.75% <60.00%> (-8.36%)	:arrow_down:
make_queue/templatetags/reservation_extra.py	94.20% <71.42%> (-1.32%)	:arrow_down:
checkin/models.py	92.59% <100.00%> (+1.52%)	:arrow_up:
contentbox/views.py	100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.