MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Refactor code to use Python 3.9 and 3.10 syntax #598

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

Proposed changes

Areas to review closely

That the refactored code retains the previous functionality.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 1 year ago

Codecov Report

Merging #598 (9c7f85f) into dev (8473975) will decrease coverage by 0.06%. The diff coverage is 77.58%.

@@            Coverage Diff             @@
##              dev     #598      +/-   ##
==========================================
- Coverage   87.76%   87.70%   -0.06%     
==========================================
  Files         133      133              
  Lines        5572     5578       +6     
==========================================
+ Hits         4890     4892       +2     
- Misses        682      686       +4     
Impacted Files Coverage Δ
internal/signals.py 40.00% <0.00%> (-2.86%) :arrow_down:
util/formfields.py 30.43% <13.33%> (-2.90%) :arrow_down:
internal/forms.py 87.15% <80.00%> (+0.24%) :arrow_up:
web/widgets.py 95.17% <84.61%> (+0.10%) :arrow_up:
make_queue/models/machine.py 88.15% <86.66%> (-0.59%) :arrow_down:
card/modelfields.py 100.00% <100.00%> (ø)
checkin/views.py 44.57% <100.00%> (ø)
dataporten/ldap_utils.py 66.66% <100.00%> (-0.78%) :arrow_down:
internal/validators.py 85.71% <100.00%> (ø)
make_queue/models/reservation.py 94.73% <100.00%> (+0.01%) :arrow_up:
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ddabble commented 1 year ago

Merging without explicit approval, as the Dev committee agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.