ddabble commented 1 year ago

Proposed changes

New features

Added two fields to event tickets: one for when the ticket was first created and one for when it was last reactivated/canceled, which can be useful for e.g. keeping statistics over when and how fast tickets were sold (754954268c39547d5015f62f2609f5a92f0dd6d3)

Improvements

Slightly improved the styling code of various ticket templates (334616b09131d083e0257af3bfc3c3e968fbd51c)
Made the red "Canceled" ribbon on tickets transparent when clicking / hovering over it, to be able to read the text behind it (1dc2dfd8f53bc8d2eec4004996668e4e6902dded)
Improved the error page for AdminEventTicketListView when trying to view the tickets connected to an Event/TimePlace, but the event is of the "wrong" type to view the tickets - i.e. viewing tickets connected to an Event that is of type REPEATING, or viewing tickets connected to a TimePlace whose event is of type STANDALONE (8e58f91d54fb50e2863aaf7e81c92abfd56989d8)

Fixes

Fixed admins not being able to cancel other users' tickets (b5d2d02e450bf84aa097c1581c752b094cb675b8)

Other changes

Set a max length of 1000 characters to event ticket comments (33e5e46936305858e99015e78d5b014f234cf8f4)
Added tests for EventTicket constraints (3787474f53d5a2613e680e588187d4702a16e406)

Areas to review closely

None in particular.

Checklist

(If any of the points are not relevant, mark them as checked)

[x] Created tests that fail without the changes, if relevant/possible
[x] Made sure that your code conforms to the code style guides and that any common code smells have been addressed
- (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
[x] Added sufficient documentation - e.g. as docstrings or in the README, if suitable
[x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
[x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server

codecov[bot] commented 1 year ago

Codecov Report

Merging #602 (3787474) into dev (d4724c8) will decrease coverage by 0.03%. The diff coverage is 87.17%.

:exclamation: Current head 3787474 differs from pull request most recent head ff2e0c0. Consider uploading reports for the commit ff2e0c0 to get more accurate results

@@            Coverage Diff             @@
##              dev     #602      +/-   ##
==========================================
- Coverage   87.69%   87.66%   -0.03%     
==========================================
  Files         134      134              
  Lines        5590     5620      +30     
==========================================
+ Hits         4902     4927      +25     
- Misses        688      693       +5

Impacted Files	Coverage Δ
news/views.py	`89.58% <81.48%> (-0.71%)`	:arrow_down:
news/admin.py	`93.52% <100.00%> (+0.07%)`	:arrow_up:
news/models.py	`98.15% <100.00%> (+0.09%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.