(It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
[x] Added sufficient documentation - e.g. as docstrings or in the README, if suitable
[x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
[x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server
Merging without explicit approval from another member, as the Dev committee agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.
Proposed changes
Fixes
Other changes
Areas to review closely
That logging in and out through Dataporten works as normal.
Deployment notes
Set the following settings in production:
COOKIE_DOMAIN = ".makentnu.no"
(note the prefixed.
)COOKIE_SECURE = True
Also, the custom
LOGOUT_URL
setting can be removed, as well as theSESSION_COOKIE_DOMAIN
setting (since it's set to the same value asCOOKIE_DOMAIN
).Checklist
(If any of the points are not relevant, mark them as checked)