MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Deployment #615

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

The dev branch has been deployed to makentnu.dev and can be manually tested there before merging.


Brings in the changes from the following PRs:

Also the following automated PRs:

Deployment notes

From #569:

The base folder for all uploaded CKEditor files was changed from ckeditor-upload to ckeditor_upload, so the existing folder on the server should be manually renamed while deploying. All references to files in that folder (only in inserted images in rich text fields, like those of articles and ContentBoxes) must also be updated - either manually on the website, or through the Django shell on the server.

From #570:

Should run python manage.py migrate database.

From #603:

Should run manage.py populate_history internal.member make_queue.machine (after migrating).

From #604:

Should set proper values for the ENROLL_MEMBERS_GUIDE_LINK, RETIRE_MEMBERS_GUIDE_LINK and QUIT_MEMBERS_GUIDE_LINK settings (through https://admin.makentnu.no/constance/config/ - after these changes have been deployed).

From #607:

Set the following settings in production:

  • COOKIE_DOMAIN = ".makentnu.no" (note the prefixed .)
  • COOKIE_SECURE = True

Also, the custom LOGOUT_URL setting can be removed, as well as the SESSION_COOKIE_DOMAIN setting (since it's set to the same value as COOKIE_DOMAIN).

From #614:

  • Move any web/local_settings.py or web/local_settings_post.py files to src/web/
  • Delete leftover empty top-level app folders
  • Uninstall the python-dataporten-auth package (see the commit message of 04230ed2cde4819ee47e05bdcbd16b745d0326b5)
  • Set Environment="PYTHONPATH=src" in the service config for the website
codecov[bot] commented 1 year ago

Codecov Report

Merging #615 (d733ef3) into main (6374f2f) will decrease coverage by 1.20%. The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   88.46%   87.27%   -1.20%     
==========================================
  Files         132      135       +3     
  Lines        5514     5672     +158     
==========================================
+ Hits         4878     4950      +72     
- Misses        636      722      +86     
Impacted Files Coverage Δ
src/announcements/admin.py 100.00% <ø> (ø)
src/announcements/forms.py 100.00% <ø> (ø)
src/announcements/models.py 93.93% <ø> (ø)
...rc/announcements/templatetags/announcement_tags.py 100.00% <ø> (ø)
src/announcements/urls.py 100.00% <ø> (ø)
src/announcements/views.py 100.00% <ø> (ø)
src/card/formfields.py 93.33% <ø> (ø)
src/card/utils.py 46.15% <ø> (ø)
src/card/validators.py 100.00% <ø> (ø)
src/card/views.py 54.16% <ø> (ø)
... and 47 more

... and 153 files with indirect coverage changes