MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Add custom `makemessages` command #620

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

Proposed changes

Override the makemessages management command in order to do the following:

Areas to review closely

That the makemessages command produces the proper output.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 1 year ago

Codecov Report

Merging #620 (d44f52d) into dev (ce12741) will decrease coverage by 0.47%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #620      +/-   ##
==========================================
- Coverage   87.70%   87.24%   -0.47%     
==========================================
  Files         134      135       +1     
  Lines        5644     5674      +30     
==========================================
  Hits         4950     4950              
- Misses        694      724      +30     
Impacted Files Coverage Δ
src/web/management/commands/makemessages.py 0.00% <0.00%> (ø)
ddabble commented 1 year ago

Merging without explicit approval from another member, as the Dev committee agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.