MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Extra view permissions for secrets #637

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

This PR depends on #636 and will automatically change base branch to dev once that PR has been merged.

Proposed changes

New features

Areas to review closely

That the buttons in the secret list work as intended, and that the extra_view_permissions are properly enforced.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 1 year ago

Codecov Report

Merging #637 (bc18a4f) into dev (2826b57) will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #637      +/-   ##
==========================================
+ Coverage   87.28%   87.38%   +0.09%     
==========================================
  Files         135      135              
  Lines        5677     5714      +37     
==========================================
+ Hits         4955     4993      +38     
+ Misses        722      721       -1     
Impacted Files Coverage Δ
src/internal/admin.py 100.00% <100.00%> (ø)
src/internal/forms.py 87.15% <100.00%> (ø)
src/internal/models.py 93.78% <100.00%> (+0.45%) :arrow_up:
src/internal/views.py 90.76% <100.00%> (+0.87%) :arrow_up:
ddabble commented 1 year ago

Merging without explicit approval from another member, as the Dev committee previously agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.