Closed ddabble closed 1 year ago
Merging #637 (bc18a4f) into dev (2826b57) will increase coverage by
0.09%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #637 +/- ##
==========================================
+ Coverage 87.28% 87.38% +0.09%
==========================================
Files 135 135
Lines 5677 5714 +37
==========================================
+ Hits 4955 4993 +38
+ Misses 722 721 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/internal/admin.py | 100.00% <100.00%> (ø) |
|
src/internal/forms.py | 87.15% <100.00%> (ø) |
|
src/internal/models.py | 93.78% <100.00%> (+0.45%) |
:arrow_up: |
src/internal/views.py | 90.76% <100.00%> (+0.87%) |
:arrow_up: |
Merging without explicit approval from another member, as the Dev committee previously agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.
This PR depends on #636 and will automatically change base branch to
dev
once that PR has been merged.Proposed changes
New features
extra_view_permissions
field to secrets (3261cdd4c226bf7a0386d5c80b45770fbc5fb06a)Areas to review closely
That the buttons in the secret list work as intended, and that the
extra_view_permissions
are properly enforced.Checklist
(If any of the points are not relevant, mark them as checked)