MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Add some PR template checkboxes #647

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

Proposed changes

Added a few things that should almost always be done before opening a PR, which are often easily forgotten - especially for newer members/contributors. With this, the checkbox list is starting to grow quite large, but I think it's still manageable, and that it strikes a decent balance between brevity and completeness.

Also split the checkbox linking to CONTRIBUTING.md in two, which should make it clearer that both the code style guide and common code smells should be followed/addressed.

Areas to review closely

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 1 year ago

Codecov Report

Merging #647 (51e1d57) into dev (ce716e9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #647   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files         135      135           
  Lines        5714     5714           
=======================================
  Hits         4993     4993           
  Misses        721      721