MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Rename various things #648

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

Proposed changes

Improvements

Other changes

Areas to review closely

References to the renamed code that I might have forgotten to update.

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 1 year ago

Codecov Report

Merging #648 (5d12ebc) into dev (ce716e9) will increase coverage by 0.01%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #648      +/-   ##
==========================================
+ Coverage   87.38%   87.39%   +0.01%     
==========================================
  Files         135      135              
  Lines        5714     5719       +5     
==========================================
+ Hits         4993     4998       +5     
  Misses        721      721              
Impacted Files Coverage Δ
src/announcements/urls.py 100.00% <ø> (ø)
src/checkin/urls.py 100.00% <ø> (ø)
src/contentbox/models.py 78.78% <0.00%> (ø)
src/docs/urls.py 100.00% <ø> (ø)
src/faq/urls.py 100.00% <ø> (ø)
src/groups/urls.py 100.00% <ø> (ø)
src/mail/email.py 43.90% <ø> (ø)
src/make_queue/urls.py 100.00% <ø> (ø)
src/news/urls.py 100.00% <ø> (ø)
src/checkin/views.py 44.57% <57.89%> (ø)
... and 35 more
ddabble commented 1 year ago

Regarding the Code Climate status check, I set it up recently on their website, but it seems like it maybe needs some tweaking 🤔 Anyway, none of the issues it lists are actually caused by changes in this PR, as things have simply been renamed/moved, so I will ignore them for this PR.

ddabble commented 1 year ago

Merging without explicit approval from another member, as the Dev committee previously agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.