Closed ddabble closed 1 year ago
Merging #648 (5d12ebc) into dev (ce716e9) will increase coverage by
0.01%
. The diff coverage is91.66%
.
@@ Coverage Diff @@
## dev #648 +/- ##
==========================================
+ Coverage 87.38% 87.39% +0.01%
==========================================
Files 135 135
Lines 5714 5719 +5
==========================================
+ Hits 4993 4998 +5
Misses 721 721
Impacted Files | Coverage Δ | |
---|---|---|
src/announcements/urls.py | 100.00% <ø> (ø) |
|
src/checkin/urls.py | 100.00% <ø> (ø) |
|
src/contentbox/models.py | 78.78% <0.00%> (ø) |
|
src/docs/urls.py | 100.00% <ø> (ø) |
|
src/faq/urls.py | 100.00% <ø> (ø) |
|
src/groups/urls.py | 100.00% <ø> (ø) |
|
src/mail/email.py | 43.90% <ø> (ø) |
|
src/make_queue/urls.py | 100.00% <ø> (ø) |
|
src/news/urls.py | 100.00% <ø> (ø) |
|
src/checkin/views.py | 44.57% <57.89%> (ø) |
|
... and 35 more |
Regarding the Code Climate status check, I set it up recently on their website, but it seems like it maybe needs some tweaking 🤔 Anyway, none of the issues it lists are actually caused by changes in this PR, as things have simply been renamed/moved, so I will ignore them for this PR.
Merging without explicit approval from another member, as the Dev committee previously agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.
Proposed changes
Improvements
Other changes
name
s of paths (84cc6b3e68e86fc265d53fe990b7c90015e56541), forms (3486ad861cbb6678b5da87ca24a03ed59a063b91) and templates (4f19eb4fb953ce9aa890f284b0f2c9bf9b0e45d2) to comply with the style guidesIndexView
toIndexPageView
, and its pathname
fromfront_page
toindex_page
(e8320f46ce3990ef4a1fcb70ca37c053c16527bb)Areas to review closely
References to the renamed code that I might have forgotten to update.
Checklist
(If any of the points are not relevant, mark them as checked)