Clean up use of "add" and "change" verbs

ddabble commented 1 year ago

Proposed changes

Fixes

Fixed board members not being allowed to add, change and delete reservation rules (e.g. the reservation rules for 3D printers) (eb16540e651364cd58c43dca360abfa288183ac3)

Other changes

Changed some URLs so that they all consistently use add (instead of create) and change (instead of edit or update), to comply with the style guide (542614586ef5e04b661680d722f4b0a0a7e7fa5d)
Made the use of add/change verbs consistent among page titles and buttons, and some other parts of the website's UI (174a83409608bd577dd2d484e6ac4319aadbe618, 549edd2dd0f71800c5e132518108bc417ef77230, bd8b6753fa0581b1c70141c8211e4227485f433e)
Made some "Add" buttons green, to follow the convention that green means to add (bd7e78ecbe79d651431ec637812d3ff486c919ed)

Areas to review closely

"Add"/"change" verbs I might have missed, and (hardcoded) URLs I might have forgotten to update after the renaming.

Checklist

(If any of the points are not relevant, mark them as checked)

[x] Created tests that fail without the changes, if relevant/possible
[x] Made sure that your code conforms to the code style guides and that any common code smells have been addressed
- (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
[x] Added sufficient documentation - e.g. as docstrings or in the README, if suitable
[x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
[x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server

codecov[bot] commented 1 year ago

Codecov Report

Merging #649 (cb30aa5) into dev (5d12ebc) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #649      +/-   ##
==========================================
+ Coverage   87.39%   87.44%   +0.05%     
==========================================
  Files         135      135              
  Lines        5719     5744      +25     
==========================================
+ Hits         4998     5023      +25     
  Misses        721      721

Impacted Files	Coverage Δ
src/announcements/urls.py	`100.00% <ø> (ø)`
src/checkin/urls.py	`100.00% <ø> (ø)`
src/contentbox/models.py	`78.78% <ø> (ø)`
src/contentbox/tests/urls/urls_internal.py	`100.00% <ø> (ø)`
src/docs/urls.py	`100.00% <ø> (ø)`
src/groups/urls.py	`100.00% <ø> (ø)`
src/internal/urls.py	`100.00% <ø> (ø)`
src/make_queue/urls.py	`100.00% <ø> (ø)`
src/makerspace/urls.py	`100.00% <ø> (ø)`
src/news/urls.py	`100.00% <ø> (ø)`
... and 14 more