MAKENTNU / web

The website of the student organization MAKE NTNU, built with Django.
https://makentnu.no
MIT License
9 stars 5 forks source link

Add Code Climate config #651

Closed ddabble closed 1 year ago

ddabble commented 1 year ago

Proposed changes

Added a .codeclimate.yml configuration file (2cc59ea06b5a5ab1faaaf749179cf3f831164cbb) for Code Climate's automated code quality checks, that add an extra status check to PRs merging into dev (this "default branch" (not necessarily the same as the one set in GitHub) was set in the "Repo Settings" tab mentioned below); see e.g. the results for #649 and the results for #650.

General and administrative settings can be found on https://codeclimate.com/github/MAKENTNU/web (log in through GitHub and a "Repo Settings" tab should appear - though this is presumably only visible for admins of this repo on GitHub).

Also made some ignores in codecov.yml more specific (81edaff096db99bde8a5ab6a27e1692f897a58c3).

Areas to review closely

Checklist

(If any of the points are not relevant, mark them as checked)

codecov[bot] commented 1 year ago

Codecov Report

Merging #651 (2cc59ea) into dev (4590b56) will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #651      +/-   ##
==========================================
+ Coverage   87.44%   87.72%   +0.27%     
==========================================
  Files         135      148      +13     
  Lines        5744     5937     +193     
==========================================
+ Hits         5023     5208     +185     
- Misses        721      729       +8     

see 21 files with indirect coverage changes

ddabble commented 1 year ago

Merging, so that we can try this out and see how well it works :)