Reorganize URL patterns, and some views and forms

ddabble commented 1 year ago

Proposed changes

Improvements

Added an additional permission check for all admin pages (incl. API endpoints), that requires the user to have the internal.is_internal permission (2103a95a279e7624159b62450e18345b82717385)
When requesting to change a ContentBox on a subdomain its path is not registered on (like trying to change the "About us" ContentBox on i.makentnu.no, or the "MAKE NTNU internsider" ContentBox on makentnu.no), you're redirected to the proper subdomain, instead of being shown a "404 Not Found" page (7f62a45a162922b7f046dbb8a1393459a511857a)

Other changes

Restructured lots of URLs to comply with the style guide (2103a95a279e7624159b62450e18345b82717385)
- The path segments (i.e. /the-text-between-the-forward-slashes/) now all have a more consistent structure, including prefixing all admin pages' paths with admin/ and all API endpoints with api/
- Permanent redirects have been added for the URLs deemed most relevant, to redirect from the old to the new URL; see a list of the added URLs in the code
Moved lots of views and forms (and some associated tests) around between files, to have them more practically organized (fbd9d6693c3037d06550114a82c802dd858ec34b, 4ef489f5ac93c3c788ef6cfeea9f910c7b015e4e)
Temporarily disabled most of the "checkin" URLs (those related to user skills, registering cards and checking in), to reduce the risk of exposing potentially insecure or buggy code (b7a05debe8d0231aa54061e66022400d801b17be)

Areas to review closely

Any (hardcoded) URLs and references to views and forms I might have forgotten to update after reorganizing.

Checklist

(If any of the points are not relevant, mark them as checked)

[x] Created tests that fail without the changes, if relevant/possible
[x] Made sure that your code conforms to the code style guides and that any common code smells have been addressed
- (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
[x] Added sufficient documentation - e.g. as docstrings or in the README, if suitable
[x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
[x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server

codecov[bot] commented 1 year ago

Codecov Report

Merging #652 (2ca1a2e) into dev (f84561b) will decrease coverage by 0.13%. The diff coverage is 89.90%.

@@            Coverage Diff             @@
##              dev     #652      +/-   ##
==========================================
- Coverage   88.29%   88.16%   -0.13%     
==========================================
  Files         147      152       +5     
  Lines        6058     6187     +129     
==========================================
+ Hits         5349     5455     +106     
- Misses        709      732      +23

Impacted Files	Coverage Δ
src/checkin/api/views.py	`0.00% <0.00%> (ø)`
src/checkin/local_scanner.py	`0.00% <0.00%> (ø)`
src/users/api/views.py	`100.00% <ø> (ø)`
src/web/admin_urls.py	`93.33% <ø> (ø)`
src/make_queue/forms/quota.py	`61.76% <61.76%> (ø)`
src/make_queue/forms/course.py	`81.57% <81.57%> (ø)`
src/make_queue/api/views.py	`96.87% <96.87%> (ø)`
src/news/api/views.py	`96.96% <96.96%> (ø)`
src/make_queue/forms/machine.py	`97.43% <97.43%> (ø)`
src/make_queue/forms/reservation.py	`97.91% <97.91%> (ø)`
... and 28 more

... and 3 files with indirect coverage changes