Open elisakiv opened 10 months ago
Merging #669 (ab926dc) into dev (6f55b7d) will increase coverage by
0.04%
. The diff coverage is96.87%
.
@@ Coverage Diff @@
## dev #669 +/- ##
==========================================
+ Coverage 88.16% 88.21% +0.04%
==========================================
Files 152 152
Lines 6187 6218 +31
==========================================
+ Hits 5455 5485 +30
- Misses 732 733 +1
Files | Coverage Δ | |
---|---|---|
src/makerspace/urls.py | 100.00% <ø> (ø) |
|
src/makerspace/views.py | 98.70% <96.87%> (-1.30%) |
:arrow_down: |
On the third plot, some of the sewing machines appear twice
On a normal screen, with two plots next to each other, the title is above the second plot. It would look better if it was in the middle. The two plots are also not situated in the middle of the page, which is fine, but then the title of the page should be adjusted relative to the plots, and not the page. The same issue is still there when the screen size gets smaller and only one plot is shown per row.
In the two plots counting how many times a 3D printer or a sewing machine has been booked by someone, it looks a bit strange that there are decimals on the y-axis, since it is impossible for a machine to be booked 0.5 times. The two other plot, on the other hand, are counting hours, so there it would have been ok to see decimals. But these plots only have integers on the y-axis. The styles should be switched – the "number of times" plots should not have decimals, and the "how many hours" plots, could.
The last plot doesn't show any numbers on the y-axis, and the axis also doesn't have a label. I guess what is shown here is the result of a calculation? Still – would it be possible to give the y-axis a label or introduce some numbers here, to make it clearer what the plot actually shows? Maybe add a label like "equipment currently in use" or "machines or workstations currently in use"?
On the x-axis on the last plot – the numbers are tilted, like for the names of 3D-printers or sewing machines. But on this plot, the only thing the x-axis shows are time points, which are shorts, so tilting them looks a bit strange.
I don't think you need a colon after the title of a plot ;-)
It might be an idea to sort the printers, either alphabetically, or to keep the same order as they appear in on the website. Now I added some fake ultimakers, then some fake raise3D printers, a fake SLA printer, and then some fake ultimakers again, and now I have the ultimakers at both sides of the plot, with raise 3D printers and SLA printers in the middle.
Aaaand now I'm done! :-) Sorry about being nitpicky :-P
Proposed changes
Created a statistics page to view statistics regariding the use of the workshop, such as reservations made, and when the workshop is in use.
Areas to review closely
Checklist
(If any of the points are not relevant, mark them as checked)
makemigrations
,makemessages
andcompilemessages
management commands and committed any changes that should be included in this PR