Feature/lore wiki page

[Gunvor4]

Proposed changes

• Added a MAKE lore wiki to the internal page, so members can write wiki articles about anything lore in the MAKE universe.

Areas to review closely

Deployment notes

• After deployment, permissions for the general MAKE group should be changed, so every member of MAKE is able to both view, add, change and delete lore articles.

Checklist

(If any of the points are not relevant, mark them as checked)

• [x] Remembered to run the makemigrations, makemessages and compilemessages management commands and committed any changes that should be included in this PR
• [x] Created tests that fail without the changes, if relevant/possible
• [x] Manually tested that the website UI works as intended with different device layouts
  • (Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools)
• [x] Manually tested that everything works as intended when logged in as different users locally
  • (This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers)
• [x] Made sure that your code conforms to the code style guides
  • (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request)
• [x] Attempted to minimize the number of common code smells
  • (See the comment for the previous checkbox)
• [x] Added sufficient documentation - e.g. as comments, docstrings or in the README, if suitable
• [x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
• [x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server
• [x] Structured your commits reasonably
  • (Some tips on this can be found in "Write Better Commits, Build Better Projects" and in the code style guides)
  • (Restructuring commits after they've already been committed, can be done using e.g. interactive rebase; see the Git docs on rewriting history)

[Gunvor4]

[codecov[bot]]

Codecov Report

Merging #675 (4d9e2a4) into dev (6f55b7d) will decrease coverage by 0.55%. The diff coverage is 56.60%.

Additional details and impacted files

[](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU) ```diff @@ Coverage Diff @@ ## dev #675 +/- ## ========================================== - Coverage 88.16% 87.62% -0.55% ========================================== Files 152 152 Lines 6187 6288 +101 ========================================== + Hits 5455 5510 +55 - Misses 732 778 +46 ``` | [Files](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU) | Coverage Δ | | |---|---|---| | [src/internal/admin.py](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL2FkbWluLnB5) | `100.00% <100.00%> (ø)` | | | [src/internal/urls.py](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL3VybHMucHk=) | `100.00% <100.00%> (ø)` | | | [src/internal/models.py](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL21vZGVscy5weQ==) | `90.39% <58.82%> (-3.40%)` | :arrow_down: | | [src/internal/views.py](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL3ZpZXdzLnB5) | `85.14% <64.15%> (-5.77%)` | :arrow_down: | | [src/internal/forms.py](https://app.codecov.io/gh/MAKENTNU/web/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL2Zvcm1zLnB5) | `75.18% <31.03%> (-11.98%)` | :arrow_down: |

[elisakiv]

It looks great, just few comments:

It seems that when the title of an article is one very long word with no spaces, it behaves strangely on mobile. The name does not wrap when it becomes too long so the title continues on one line, past the length of the header.

When the title is long, but does contain spaces, the placement of the edit and delete button is a little awkward.

[elisakiv]

If a users adds an article with a name only consiting of special character, the page crashes.

[elisakiv]

When editing an article with a picture, the button and checkbox for removing the picture behaves a little strangely. The checkbox is not level with the picure name, and the "Clear" button does not fully behave like a button, mainly because the cursor does not become a hand, the user does not receive any feedback that the button was clicked, and it does not look like a button either, it looks like the other text on the page.

[elisakiv]

If the article has a very long name, the title in the menu overlaps with the text of the article that the user has open

[ddabble]

Btw, regarding the deployment notes in the PR description, it might be wise to not let all members of MAKE delete lore articles, and instead only grant that permission to e.g. the board members - similar to the group permissions for the internal quotes currently on the website 🤔 What do you think?