Remove Discord username validation

[Gunvor4]

Proposed changes

Removed the regex validating Discord usernames, since Discord somewhat recently changed their username format (see https://discord.com/blog/usernames and https://support.discord.com/hc/en-us/articles/12620128861463-New-Usernames-Display-Names). Also removed the help_text explaining the old username format.

Areas to review closely

Checklist

(If any of the points are not relevant, mark them as checked)

• [x] Remembered to run the makemigrations, makemessages and compilemessages management commands and committed any changes that should be included in this PR
• [x] Created tests that fail without the changes, if relevant/possible
• [x] Manually tested that the website UI works as intended with different device layouts
  • (Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools)
• [x] Manually tested that everything works as intended when logged in as different users locally
  • (This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers)
• [x] Made sure that your code conforms to the code style guides
  • (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request)
• [x] Attempted to minimize the number of common code smells
  • (See the comment for the previous checkbox)
• [x] Added sufficient documentation - e.g. as comments, docstrings or in the README, if suitable
• [x] Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
• [x] Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server
• [x] Structured your commits reasonably
  • (Some tips on this can be found in "Write Better Commits, Build Better Projects" and in the code style guides)
  • (Restructuring commits after they've already been committed, can be done using e.g. interactive rebase; see the Git docs on rewriting history)

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.15%. Comparing base (54d6901) to head (74b3839). Report is 4 commits behind head on dev.

Additional details and impacted files

[](https://app.codecov.io/gh/MAKENTNU/web/pull/717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU) ```diff @@ Coverage Diff @@ ## dev #717 +/- ## ========================================== - Coverage 88.15% 88.15% -0.01% ========================================== Files 152 152 Lines 6188 6186 -2 ========================================== - Hits 5455 5453 -2 Misses 733 733 ``` | [Files](https://app.codecov.io/gh/MAKENTNU/web/pull/717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU) | Coverage Δ | | |---|---|---| | [src/internal/models.py](https://app.codecov.io/gh/MAKENTNU/web/pull/717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL21vZGVscy5weQ==) | `93.78% <100.00%> (ø)` | | | [src/internal/validators.py](https://app.codecov.io/gh/MAKENTNU/web/pull/717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MAKENTNU#diff-c3JjL2ludGVybmFsL3ZhbGlkYXRvcnMucHk=) | `84.21% <ø> (-1.51%)` | :arrow_down: |

[elisakiv]

The help text also need to be updated in the member model, the discord field in the Django admin panel still asks for the username to include the hashtag and the numbers

[ddabble]

Did you remember to run makemigrations? These changes to the model will necessarily create a new migration :p None of the changes affect the database schema in any way, though, so I think it's better to simply remove help_text (and validators, re: my comment above) from the internal migrations 0015 and 0024 - which are the only ones that include those arguments of the discord_username field 🙂

We can also remove the translation strings for the previous help_text (and discord_username_validator) from django.po; recompiling django.mo shouldn't be necessary, though it won't hurt :)

[Gunvor4]

Did you remember to run makemigrations? These changes to the model will necessarily create a new migration :p None of the changes affect the database schema in any way, though, so I think it's better to simply remove help_text (and validators, re: my comment above) from the internal migrations 0015 and 0024 - which are the only ones that include those arguments of the discord_username field 🙂

We can also remove the translation strings for the previous help_text (and discord_username_validator) from django.po; recompiling django.mo shouldn't be necessary, though it won't hurt :)

Done and done :-)