search

MALI-Dev / E3SM

Repository for development of MPAS-Albany-Land Ice (MALI) model. MALI code is located in the `components/mpas-albany-landice` subdirectory of the Energy Exascale Earth System Model (E3SM) repository.
Other
4 stars 3 forks source link

Fix dissipation when solver fails #97

Closed matthewhoffman closed 10 months ago

matthewhoffman commented 10 months ago

When the velocity solver fails, the internal dissipation field it returns can have large artifacts in it that lead to unphysical melt rates being applied. This merge skips updating the heatDissipation field when the solver fails so that the previous timestep's value is retained.

matthewhoffman commented 10 months ago

Testing

A recent AIS run showed weird melt rates occasionally: image Some investigating indicated that this occurs on a timestep after one in which the velocity solver failed to converge, which led to the fix in this PR.

After this fix, the same run looks correct: image