MAPC / datacommon

MAPC's Data Portal
https://datacommon.mapc.org/
3 stars 0 forks source link

Adjust dates for community profile charts #355

Closed atomtay closed 4 years ago

atomtay commented 4 years ago

Resolves #351 (somewhat) .

Why is this change necessary?

Some community profile charts were displaying out-of-date information or incorrect labels (say, they were pulling 2018 data but the axis suggested it was 2016 data)

How does it address the issue?

I manually went through the /constants/charts.js file and checked each chart's data source to see if there was new data we should be referencing. This mostly involved just updating labels, but did require updating a couple references to acs_year so that the correct data would come through.

What side effects does it have?

This doesn't automate things so much as keep them up-to-date as of now. I wrote a little more in the issue itself, but I think that examining and implementing automation for both the data and the labels would take vastly more time than occasionally checking the charts and updating values as they come up. If we do move away from PRQL (tagging #319 for cross-listing purposes) then this would be a good feature to keep in mind as we set up a new system. I recommend setting up something like a Slack notification every 6 months or so to remind us to check the chart data and see if anything needs updating.