search

MAPC / massbuilds-legacy

Crowdsourcing authoritative info on recent & ongoing developments in Massachusetts.
3 stars 5 forks source link

Nearest Transit Feature Fails on Far Flung Addresses #172

Open mzagaja opened 7 years ago

mzagaja commented 7 years ago

If a user attempts to add an address that is far from MBTA transit stops the app throws the following error:

Internal Server Error: undefined method `[]' for nil:NilClass /Users/mzagaja/GitHub/massbuilds/lib/nearest_transit.rb:29:in `bus_stop'
/Users/mzagaja/GitHub/massbuilds/lib/nearest_transit.rb:17:in `stop_name'
/Users/mzagaja/GitHub/massbuilds/lib/nearest_transit.rb:11:in `get'
/Users/mzagaja/GitHub/massbuilds/app/models/concerns/development/model_callbacks.rb:59:in `update_nearest_transit'

Failing to find a transit stop should not cause the app to fail loudly, this should be a silent failure and the development should still be created.