search

MAPC / massbuilds-legacy

Crowdsourcing authoritative info on recent & ongoing developments in Massachusetts.
3 stars 5 forks source link

Fix #180 Allow User to Leave Organization #188

Closed mzagaja closed 6 years ago

mzagaja commented 7 years ago

Fixes the route to use the POST verb so that the organization leaving function works.

allthesignals commented 7 years ago

Thanks! This prevents the error from occurring, but even when successfully clicking "leave organization," it doesn't seem to leave... looking at the database (User.find_by_email("mgardner@mapc.org").memberships.map(&:organization).map(&:name)) shows the memberships as still existing. That means there's probably something wrong with the membership.deactivated method which is invoked in the organizations controller action. Let me know if you want me to look at this some more - it's pretty small fries and I know you've got other things to worry about. On top of that it's not really a widely used feature... let me know how you'd like to proceed with this PR. This is the correct direction anyway.

mzagaja commented 7 years ago

Ok I think it's not worth merging this in yet then. I just sort of believe the message I received when I tested it. Good catch on it not actually leaving the org.