search

MAPC / metro-mayors-housing-task-force

Static Site for Metro Mayor's Task Force on Housing
https://housingtaskforce.mapc.org/
MIT License
1 stars 0 forks source link

Media queries should bubble downward, not upward #28

Closed ericyoungberg closed 6 years ago

ericyoungberg commented 6 years ago

Mobile first design makes sense on a canvas during the actual design process, but it doesn't translate well into code. You should develop for the largest screen size then include media queries for when the screen gets smaller. With good html/css, It's much easier to take something away than inject something that wasn't a part of the layout before.

arouault commented 6 years ago

Should be implemented with mobile design implementation.

mzagaja commented 6 years ago

I consulted with some other folks about this who asserted to me:

Upwards. Using min-width queries helps enforce a mobile-first mindset Plus it means less work processing the CSS for mobile devices, which benefit the most from the lighter load

Googling also seems to suggest upwards is the convention used in most examples. This is not to say this idea does not make sense in this situation but I have not found much support for the above approach. Though I would be interested in authority that supports this suggestion further.

mzagaja commented 6 years ago

On this one I decided to follow your suggestion and bubble down since as I refactored there was not much of a change to make and it was easy to invert. See i.e. https://github.com/MAPC/metro-mayors-housing-task-force/pull/55/files#diff-3f4df008eba5202793cb8dca9c6bc314. Going to close this issue on this specific project but think we can philosophize further on it in future ones.