MAPC / myschoolcommute

Walk Boston Parent Survey
http://myschoolcommute.org
GNU General Public License v3.0
2 stars 1 forks source link

Created date not assigned for online (non-batch) surveys #78

Closed TimReardon closed 9 years ago

TimReardon commented 9 years ago

Surveys entered by parents using online interface (either map point location or cross streets) are not assigned a created date, and can therefore not be assigned to a survey set.

Is this a consequence of the fix that was made for the bulk entry forms?

demiurg commented 9 years ago

Yes, because the batch form sets the created field manually, its not automatically populating. However, the modified field should be automatically being populated and can be used instead.

TimReardon commented 9 years ago

But that means the online (non-batch) surveys are useless for analysis, unless we manually assign a created date. It seems that your solution to the bulk entry date problem simply created another problem elsewhere. How do you propose to fix it?

demiurg commented 9 years ago

The modified field should be automatically being populated and can be used instead.

demiurg commented 9 years ago

I also wouldn't use the word 'simply' in relation to this system. The solution to the bulk entry date problem solved a problem, because it made it required to set the field manually. The field now has to be set manually when creating the survey result in other places. This is an unintended consequence, not a simple consequence and should have been exposed with testing. Fortunately it doesn't impact the data, since a query can be ran to assign the modified value to the created field. I can also set it manually in the user entry form at the creation time.

demiurg commented 9 years ago

This is fixed.