search

MARIO-Math-Reasoning / Super_MARIO

MIT License
258 stars 17 forks source link

Potential Wrong Logic #21

Closed sfc-gh-zhyao closed 1 month ago

sfc-gh-zhyao commented 1 month ago

https://github.com/MARIO-Math-Reasoning/Super_MARIO/blob/main/mcts_math/agents/mcts.py#L69

Should this line be 

while node.has_children() and (not node.is_terminal):
sfc-gh-zhyao commented 1 month ago

I see the logic, is_terminal is just to track if the node is good for expand or not

Chen-GX commented 1 month ago

Yes, you are right. We won't choose a terminal node again in our released code, because we want to explore more unterminal nodes. Of course, you can delete and (not node.is_terminal).