search

MASQ-Project / Node

MASQ combines the benefits of VPN and Tor technology to create a superior next-generation privacy software, where users are rewarded for supporting an uncensored global web. Users gain privacy and anonymity online, while helping promote Internet Freedom.
https://masqbrowser.com
Other
175 stars 29 forks source link

Enable Link-Time Optimization (LTO) #535

Open zamazan4ik opened 1 month ago

zamazan4ik commented 1 month ago

Is your feature request related to a problem? Please describe. Not a problem - just a performance improvement idea.

Describe the solution you'd like I noticed that in the Cargo.toml files Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit.

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional dist or release-lto profile where additionally to regular release optimizations LTO will also be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO should also help to reduce the build-time overhead with LTO. E.g., check cargo-outdated Release profile.

Basically, it can be enabled with the following lines:

[profile.release]
lto = true

I also found this comment in discussions with an LTO mention.

Describe alternatives you've considered Leave things as is

Additional context N/A

kauri-hero commented 1 month ago

Thanks for your input and interest in the project!

Will discuss with devs and triage this CC: @dnwiebe @bertllll @czarte