search

MASTmultiphysics / mast-multiphysics

Multidisciplinary-design Adaptation and Sensitivity Toolkit (MAST) - Sensitivity-enabled multiphysics FEA for design
https://www.mast-multiphysics.com
GNU Lesser General Public License v2.1
44 stars 24 forks source link

Update for compatibility with libMesh v1.5.0 #48

Closed jdeaton closed 4 years ago

jdeaton commented 4 years ago

Due to some header refactoring in libMesh in the v1.5.0 release, some extra includes are now required.

See: https://github.com/libMesh/libmesh/pull/2219, https://github.com/grinsfem/grins/pull/592, and https://github.com/libMesh/libmesh/issues/2337.

The main one was where we were previously using .comm().sum() for sums across processors, we now need to #include libmesh/parallel.h. Other small changes required #include libmesh_logging.h.

Pull in https://github.com/MASTmultiphysics/mast-multiphysics/pull/47 before this one. All CI builds should work after this.

manavbhatia commented 4 years ago

The modifications here seem to be similar to those in #47, which did not pass travis CI.

Do you still want to pull #47 before this?

jdeaton commented 4 years ago

Yea, the reason #47 didn't pass was that it is actually setup to try 3 different versions of libMesh also. If you go to details in Travis-CI of the run in that PR, you still see that it passes for libMesh 1.3/1.4 on both Linux and macOS, but at that time it was still incompatible with 1.5, which was the failings. This PR fixes the 1.5 issues then.