Closed JohnDN90 closed 4 years ago
A number of updates in this pull request now:
docs/assets
over to a git submodule where the files are now located at https://github.com/MASTmultiphysics/mast-assets.Since we have the big change of the submodule in this, might only want to do the "Merge pull request" option and not the "Squash and merge" to keep those commits separated for clarity.
Looks like the build is currently only failing with libMesh v1.3.1. I think we should just drop support for that since its working with the newer libMesh 1.4.1 and 1.5.0.
Looks like the build is currently only failing with libMesh v1.3.1. I think we should just drop support for that since its working with the newer libMesh 1.4.1 and 1.5.0.
Just fixed this. Looks like it was related to the refactoring that the libMesh team did. Question remains whether we should drop support since they did clean up the includes in the more recent versions.
I would recommend to create a mast-multiphysics/contrib
folder for non-MAST codes, instead of mast-multiphysics/contrib/external
. This way, libfort
can reside as a clone of the original repository in `mast-multiphysics/contrib/libfort'.
I just went ahead and reorganized as you suggested and moved the external source into ROOT/contrib/libfort
. This required a little bit of CMake refactoring.
The reason I originally set it up with ROOT/src/external
was to try to simplify CMake, but I think it actually made things a bit more confusing and probably only made sense to me.
Once the last changes clear Travis-CI I'm going to go ahead and merge this PR in.
Thanks! Yes, I think we can merge after this change.
Just a sidenote: I pushed a commit #54 yesterday fixing the mass matrix issue for beam element that John had raised. I would recommend that you verify the results of your Nastran example with this update.
This adds the feature of importing meshes from a Nastran input file by utilizing an interface to pyNastran.