Closed JohnDN90 closed 4 years ago
Did you mean to point to clear() instead?
I think we can remove this assert statement. It should not matter whether or not the object is initialized since all the unique_ptr
s are cleared anyways.
Yes, my link was actually pointing to clear() when this issue was created, but then the line numbers changed and the link was no longer correct after we merged in some changes last week. Going forward, it might be better for me to reference the name of the file and the name of the function in the link text, so if line numbers change we don't run into this confusion.
And that sounds good. This assert statement was causing one of my unit tests to fail when I tried clearing a section property card after I had initialized it.
Closed in PR #70
@manavbhatia Here, should
libmesh_assert(!_initialized);
actually belibmesh_assert(_initialized);
?The unique_ptr should already be pointing to null before initialization and logically you would only need to clear your property card, after it has been initialized, not before. If I'm missing something, could you explain what it is?